Skip to content

adding default to connection_settings #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 18, 2021
Merged

adding default to connection_settings #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92a5a93
adding default to connection_settings
roshan04 Mar 17, 2021
911d257
removing unwanted file
roshan04 Mar 17, 2021
b370cd0
handle extra case
roshan04 Mar 17, 2021
39a917d
added object to connection_settings
roshan04 Mar 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions bin/helpers/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,12 @@ exports.setDefaults = (bsConfig, args) => {
if (bsConfig.run_settings && this.isUndefined(bsConfig.run_settings.npm_dependencies)) {
bsConfig.run_settings.npm_dependencies = {}
}

// setting connection_settings to {} if not present
if (this.isUndefined(bsConfig.connection_settings)) {
bsConfig.connection_settings = {};
}

}

exports.setUsername = (bsConfig, args) => {
Expand Down
17 changes: 17 additions & 0 deletions test/unit/bin/helpers/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1428,6 +1428,23 @@ describe('utils', () => {
expect(utils.isUndefined(bsConfig.auth)).to.be.true;
expect(utils.isUndefined(bsConfig.run_settings.npm_dependencies)).to.be.false;
});

it ('should set connection_settings if bsConfig.connection_settings is undefined' , () => {
let bsConfig = { run_settings: {} };
utils.setDefaults(bsConfig, {});
expect(utils.isUndefined(bsConfig.connection_settings)).to.be.false;
});

it('should not set connection_settings if bsConfig.connection_settings is defined ', () => {
let bsConfig = {
run_settings: {},
connection_settings: {
local: "false"
}
};
utils.setDefaults(bsConfig, {});
expect(bsConfig.connection_settings).to.deep.equal({local: "false"});
});
});

describe('getNumberOfSpecFiles', () => {
Expand Down