Skip to content

removed local object creation #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2021
Merged

removed local object creation #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 23 additions & 17 deletions test/unit/bin/helpers/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,7 +837,7 @@ describe('utils', () => {
});

describe('setupLocalTesting' ,() => {

beforeEach(function () {
sinon.restore();
sandbox.restore();
Expand Down Expand Up @@ -985,12 +985,13 @@ describe('utils', () => {
it('stopLocalBinary promise resolves with undefined if the bs_local isRunning is false' ,() => {
let bsConfig = {
connection_settings: {
local_mode: true
local_mode: "on-demand"
}
};
let bs_local = new browserstack.Local();
let isRunningStub = sinon.stub(bs_local,"isRunning");
isRunningStub.returns(false);
let isRunningStub = sandbox.stub().returns(false);
let bs_local = {
isRunning: isRunningStub,
};
return utils.stopLocalBinary(bsConfig, bs_local).then((result) => {
expect(result).to.be.eq(undefined);
});
Expand All @@ -1002,24 +1003,27 @@ describe('utils', () => {
local_mode: "always-on"
}
};
let bs_local = new browserstack.Local();
let isRunningStub = sinon.stub(bs_local,"isRunning");
isRunningStub.returns(true);
let isRunningStub = sandbox.stub().returns(true);
let bs_local = {
isRunning: isRunningStub,
}
return utils.stopLocalBinary(bsConfig, bs_local).then((result) => {
expect(result).to.be.eq(undefined);
});
});

it('if the bs_local isRunning is true and local_mode is not always-on and there is no stop error, then gets resolve with undefined' ,() => {
let bsConfig = {
connection_settings: {
local_mode: "on-demand"
}
};
let bs_local = new browserstack.Local();
let isRunningStub = sinon.stub(bs_local,"isRunning");
isRunningStub.returns(true);
sinon.stub(bs_local,"stop").yields(undefined);
let isRunningStub = sandbox.stub().returns(true);
let stopStub = sandbox.stub().yields(undefined);
let bs_local = {
isRunning: isRunningStub,
stop: stopStub
}
return utils.stopLocalBinary(bsConfig, bs_local).then((result) => {
expect(result).to.be.eq(undefined);
});
Expand All @@ -1031,11 +1035,13 @@ describe('utils', () => {
local_mode: "on-demand"
}
};
let bs_local = new browserstack.Local();
let isRunningStub = sinon.stub(bs_local,"isRunning");
isRunningStub.returns(true);
let isRunningStub = sandbox.stub().returns(true);
let error = new Error('Local Stop Error');
let stopStub = sinon.stub(bs_local,"stop").yields(error);
let stopStub = sandbox.stub().yields(error);
let bs_local = {
isRunning: isRunningStub,
stop: stopStub
}
let sendUsageReportStub = sandbox
.stub(utils, 'sendUsageReport')
.callsFake(function () {
Expand Down