Skip to content

Conversation

karanshah-browserstack
Copy link
Collaborator

Added local_mode(on-demand/always-on).
Added cli args i.e. local, local_identifier & local_mode.
Updated --help to support new cli args
Downloading and starting of binary on runtime if the user hasn't started the binary.

karanshah-browserstack and others added 24 commits February 19, 2021 18:14
Calculate local_identifier based on local_mode.
- Adding checks and params for local, local mode, and sync inferred.
- If the user passed anything explicitly, then it is not inferred.
- This is to understand which of the "auto-fallback" flows does CLI fall in.
- Inverted the logic of the *_inferred events.
Copy link
Collaborator

@SagarGaniga SagarGaniga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suryart suryart merged commit ff9be4d into master Mar 12, 2021
@suryart suryart deleted the improve_local_testing branch March 12, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants