Skip to content

Changing title to BrowserStack and width to 100 instead of 50 #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 18, 2020
Merged

Changing title to BrowserStack and width to 100 instead of 50 #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dae9a74
Changing title to BrowserStack and width to 80 instead of 50
karanshah-browserstack Dec 16, 2020
3de1cfe
Unit test case fix
karanshah-browserstack Dec 16, 2020
c0673d2
Changing width to 100
karanshah-browserstack Dec 16, 2020
0c87b71
Changing default width to 30
karanshah-browserstack Dec 17, 2020
6092cc8
Fixing width of failed specs table
karanshah-browserstack Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/helpers/reporterHTML.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ function renderReportHTML(report_data) {
let resultsDir = 'results';
let metaCharSet = `<meta charset="utf-8">`;
let metaViewPort = `<meta name="viewport" content="width=device-width, initial-scale=1"> `;
let pageTitle = `<title> Browserstack Cypress Report </title>`;
let pageTitle = `<title> BrowserStack Cypress Report </title>`;
let inlineCss = `<style type="text/css"> ${loadInlineCss()} </style>`;
let head = `<head> ${metaCharSet} ${metaViewPort} ${pageTitle} ${inlineCss} </head>`;
let htmlOpenTag = `<!DOCTYPE HTML><html>`;
Expand Down
4 changes: 2 additions & 2 deletions bin/helpers/sync/failedSpecsDetails.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ let failedSpecsDetails = (data) => {
let tableConfig = {
border: tablePrinter.getBorderCharacters('ramac'),
columns: {
0: { alignment: 'left' },
0: { alignment: 'left' , width: 60 },
1: { alignment: 'left' },
2: { alignment: 'left' },
3: { alignment: 'left' },
Expand All @@ -65,7 +65,7 @@ let failedSpecsDetails = (data) => {
* @return {boolean}
*/
drawHorizontalLine: (index, size) => {
return (index === 0 || index === 1 || index === size);
return (index === 0 || index === 1 || index === specData.length);
}
}

Expand Down
4 changes: 2 additions & 2 deletions bin/helpers/sync/syncSpecsLogs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ let getTableConfig = () => {
border: getBorderConfig(),
columns: {
1: {alignment: 'center', width: 1},
2: {alignment: 'left', width: 50}
2: {alignment: 'left', width: 100}
},
columnDefault: {
width: 25,
width: 30,
},
columnCount: 3,
};
Expand Down
4 changes: 2 additions & 2 deletions test/unit/bin/helpers/sync/syncSpecsLogs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,11 @@ describe("syncSpecsLogs", () => {
syncSpecsLogs.__set__('getBorderConfig', getBorderConfigStub);

let options = getTableConfig();
expect(options.columnDefault.width).to.equal(25);
expect(options.columnDefault.width).to.equal(30);
expect(options.columns[1].alignment).to.equal('center');
expect(options.columns[2].alignment).to.equal('left');
expect(options.columns[1].width).to.equal(1);
expect(options.columns[2].width).to.equal(50);
expect(options.columns[2].width).to.equal(100);
expect(options.columnCount).to.equal(3);
expect(getBorderConfigStub.calledOnce).to.be.true;
});
Expand Down