Cypress Build Unification #1002
Conversation
Tanmay-Bstack
requested review from
07souravkunda and
karanshah-browserstack
and removed request for
07souravkunda and
karanshah-browserstack
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const options = { | ||
| hostname: '127.0.0.1', | ||
| port, | ||
| path: `/test-uuid?testIdentifier=${encodeURIComponent(testIdentifier)}`, | ||
| method: 'GET', | ||
| timeout: 2000 | ||
| }; | ||
| const req = http.request(options, (res) => { | ||
| let data = ''; | ||
| res.on('data', (chunk) => data += chunk); | ||
| res.on('end', () => { | ||
| if(res.statusCode === 200) { | ||
| try { | ||
| const json = JSON.parse(data || '{}'); | ||
| return resolve({ testRunUuid: json.testRunUuid || null }); | ||
| } catch(e) { | ||
| return resolve(null); | ||
| } | ||
| } else if (res.statusCode === 404) { | ||
| // Server up but endpoint not responding as expected – stop retrying. | ||
| return resolve(null); | ||
| } else { | ||
| retryOrResolve(); | ||
| } | ||
| }); | ||
| }); |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: problem-based-packs.insecure-transport.js-node.http-request.http-request Warning
| method: 'GET', | ||
| timeout: 2000 | ||
| }; | ||
| const req = http.request(options, (res) => { |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: problem-based-packs.insecure-transport.js-node.using-http-server.using-http-server Warning
bin/testhub/testhubHandler.js
Outdated
| } | ||
| } | ||
|
|
||
| module.exports = TestHubHandler; No newline at end of file |
bin/testhub/utils.js
Outdated
| accessibility: accessibilityScanInfo[testData.name], | ||
| }; | ||
| } | ||
| }; No newline at end of file |
| exports.isAccessibilityEnabled = () => { | ||
| if (process.env.BROWSERSTACK_TEST_ACCESSIBILITY !== undefined) { | ||
| return process.env.BROWSERSTACK_TEST_ACCESSIBILITY === "true"; | ||
| } |
There was a problem hiding this comment.
Please add a log here for better clarity
| this.platformDetailsMap = {}; | ||
| this.runStatusMarkedHash = {}; | ||
| this.haveSentBuildUpdate = false; | ||
| this.startHttpServer(); |
There was a problem hiding this comment.
keep it in try catch if any how it fails to start and throw error
There was a problem hiding this comment.
Added try catch block inside the function
| if(this.httpServer !== null) return; | ||
|
|
||
| try { | ||
| this.httpServer = http.createServer(async(req, res) => { |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: problem-based-packs.insecure-transport.js-node.using-http-server.using-http-server Warning test
Uh oh!
There was an error while loading. Please reload this page.