Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/async.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ module.exports = function resolve(x, options, callback) {

if (/^(?:\.\.?(?:\/|$)|\/|([A-Za-z]:)?[/\\])/.test(x)) {
var res = path.resolve(y, x);
if (x === '..') res += '/';
if (x === '..' || x.slice(-1) === '/') res += '/';
if (/\/$/.test(x) && res === y) {
loadAsDirectory(res, opts.package, onfile);
} else loadAsFile(res, opts.package, onfile);
Expand Down
2 changes: 1 addition & 1 deletion lib/sync.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ module.exports = function (x, options) {

if (/^(?:\.\.?(?:\/|$)|\/|([A-Za-z]:)?[/\\])/.test(x)) {
var res = path.resolve(y, x);
if (x === '..') res += '/';
if (x === '..' || x.slice(-1) === '/') res += '/';
var m = loadAsFileSync(res) || loadAsDirectorySync(res);
if (m) return m;
} else {
Expand Down
16 changes: 16 additions & 0 deletions test/resolver.js
Original file line number Diff line number Diff line change
Expand Up @@ -278,3 +278,19 @@ test('#25: node modules with the same name as node stdlib modules', function (t)
t.equal(res, path.join(resolverDir, 'node_modules/punycode/index.js'));
});
});

test('#52 - incorrectly resolves module-paths like "./someFolder/" when there is a file of the same name', function (t) {
t.plan(2);

var dir = path.join(__dirname, 'resolver');

resolve('./foo', { basedir: path.join(dir, 'same_names') }, function (err, res, pkg) {
if (err) t.fail(err);
t.equal(res, path.join(dir, 'same_names/foo.js'));
});

resolve('./foo/', { basedir: path.join(dir, 'same_names') }, function (err, res, pkg) {
if (err) t.fail(err);
t.equal(res, path.join(dir, 'same_names/foo/index.js'));
});
});
1 change: 1 addition & 0 deletions test/resolver/same_names/foo.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
module.exports = 42;
1 change: 1 addition & 0 deletions test/resolver/same_names/foo/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
module.exports = 1;
13 changes: 13 additions & 0 deletions test/resolver_sync.js
Original file line number Diff line number Diff line change
Expand Up @@ -204,3 +204,16 @@ test('#79 - re-throw non ENOENT errors from stat', function (t) {
t.end();
});

test('#52 - incorrectly resolves module-paths like "./someFolder/" when there is a file of the same name', function (t) {
var dir = path.join(__dirname, 'resolver');

t.equal(
resolve.sync('./foo', { basedir: path.join(dir, 'same_names') }),
path.join(dir, 'same_names/foo.js')
);
t.equal(
resolve.sync('./foo/', { basedir: path.join(dir, 'same_names') }),
path.join(dir, 'same_names/foo/index.js')
);
t.end();
});