Don't preserve symlinks when resolving deps

[zkochan]

For context see: browserify/resolve#131

This fixes browserify for projects that use pnpm.
Related issue at pnpm: pnpm/pnpm#795

[zkochan]

Hello people. Could someone have a look at this PR, please?

[goto-bus-stop]

Yes! thanks for the bump.

Just to make sure I understand: is this also what is toggled by the --preserve-symlinks flag in Node? i.e., module-deps was always acting as if --preserve-symlinks was passed, while the default should be to act as if it was not?

[zkochan]

Yes, you are correct.

Also, this may be a breaking change. It will unlikely break anything but it does change the way packages are resolved.

[goto-bus-stop]

Oh I see this is only changing it for transforms—i think that should be pretty safe. there is another PR open in browserify that adds a --preserve-symlinks flag for modules that will be bundled: browserify/browserify#1742.

[goto-bus-stop]

Will merge & publish this ASAP together with the browserify --preserve-symlinks PR. sorry for the wait.

[zkochan]

When would this be published?

[goto-bus-stop]

releasing today in module-deps@6 and browserify@16! apologies for the slowness—i'm still a bit scared of doing breaking browserify releases because so many people use it and it's tough to wrap my head around everyone's use cases 😅