Review: Style and Patterns #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eation actions refactor(files): update selector names to follow simplified name model used in other BrieBug projects refactor(files): update imports to move away from terrible 'fromWhatever' importing style
src/ngrx-entity/__files__/__name@dasherize@if-flat__/__name@dasherize__.actions.ts
Outdated
Show resolved
Hide resolved
| } = from<%= classify(name) %>State.adapter.getSelectors(get<%= classify(name) %>State); | ||
| selectIds: <%= name %>Ids, | ||
| selectEntities: <%= name %>Entities, | ||
| selectAll: <%= name %>, |
| selectAll: getAll<%= classify(name) %>EntitiesAsArray, | ||
| selectTotal: getTotal<%= classify(name) %>Entities | ||
| } = from<%= classify(name) %>State.adapter.getSelectors(get<%= classify(name) %>State); | ||
| selectIds: <%= name %>Ids, |
jessesanders
requested changes
Apr 24, 2019
…sherize__.actions.ts
jessesanders
approved these changes
Apr 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(files): update files to use Create rather than Insert for creation actions
refactor(files): update selector names to follow simplified name model used in other BrieBug projects
refactor(files): update imports to move away from terrible 'fromWhatever' importing style