Add support for certificates for secure mode. #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for an optional Certifying Authority certificate as well as a Client certificate and key for use with secure mode. Allowing git2consul to be used with servers that have verify_incoming turned on. Consul client library had to be upgraded to pick up a new enough version of the node consul client library and it's dependency papi to support this.
|
would you have a ready to use binary for this PR ? I definitely need this and would be happy to test it :) |
|
+1 would love to have this option too and test asap. |
monwolf
added a commit
to monwolf/git2consul
that referenced
this pull request
Jul 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for an optional Certifying Authority certificate as well as
a Client certificate and key for use with secure mode. Allowing
git2consul to be used with servers that have verify_incoming turned on.
Consul client library had to be upgraded to pick up a new enough version
of the node consul client library and it's dependency papi to support
this.