Retrying connection to consul to avoid purge if consul is not available #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guylain
reviewed
Mar 21, 2017
lib/consul/index.js
Outdated
| return; | ||
| } | ||
| /* istanbul ignore if */ | ||
| if (err) return cb(err); |
There was a problem hiding this comment.
I think this is useless and should be removed as there should not be an err at this point.
|
@samifruit514 thanks for the PR! Unfortunately, I no longer have committer access to the project so you'll have to get in touch with one of the guys from @Cimpress-MCP to get this in. @ryanbreen might be able to give you further guidance. |
|
I think this PR could be a fairly important feature to integrate, isn't it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.