Fixed problems with color ANSI sequences and ported to Cygwin #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least "vagrant global-status | od -c" produces:
\n 033 [ 0 m - -
before delimiter ----...-- ID so regex /^-+$/ is failed.
There is --no-color flag but I am not sure about backward compatibility.
So ended with VAGRANT_NO_COLOR env var which is the most unintrusive way to
introduce fix.
https://www.vagrantup.com/docs/other/environmental-variables.html
…orks within Cygwin's Bash with native Windows build of Vagrant. # vagrant help | od -c \r \n \r \n - v , - - v e r s i o n It is possible to strip \r by piping through 'tr -d $"\n"' at cost of extra process but completion is already slow on Windows so it's better to handle CR in awk at cost of readability. Only __vagrant_get_snapshots wasn't updated as I found it difficult to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.