Flat container builders #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rust Benchmark
| Benchmark suite | Current: 352d7a2 | Previous: eb5c30c | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
2218538341 ns/iter (± 12515353) |
2278858883 ns/iter (± 38485237) |
0.97 |
rule-match-first-request/brave-list |
1056396 ns/iter (± 68056) |
1019219 ns/iter (± 12255) |
1.04 |
blocker_new/brave-list |
148103386 ns/iter (± 604955) |
162380552 ns/iter (± 5943396) |
0.91 |
blocker_new/brave-list-deserialize |
63609511 ns/iter (± 559308) |
65009694 ns/iter (± 2409298) |
0.98 |
memory-usage/brave-list-initial |
17605276 ns/iter (± 3) |
17549140 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-initial/max |
64817658 ns/iter (± 3) |
64817658 ns/iter (± 3) |
1 |
memory-usage/brave-list-initial/alloc-count |
1515380 ns/iter (± 3) |
1515544 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-1000-requests |
2516487 ns/iter (± 3) |
2505576 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-1000-requests/alloc-count |
66641 ns/iter (± 3) |
66123 ns/iter (± 3) |
1.01 |
url_cosmetic_resources/brave-list |
211410 ns/iter (± 1809) |
213731 ns/iter (± 2730) |
0.99 |
cosmetic-class-id-match/brave-list |
4261364 ns/iter (± 1162191) |
4346725 ns/iter (± 1205995) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
atuchin-m
force-pushed
the
flat-containter-builders
branch
from
e74ef6e to
6e0e572
Compare
boocmp
approved these changes
Aug 15, 2025
antonok-edm
approved these changes
Aug 15, 2025
Comment on lines
-6
to
-7
| // Should be 4 while we support armv7 and x86_32. | ||
| const MIN_ALIGNMENT: usize = 4; |
There was a problem hiding this comment.
no longer supporting 32-bit architectures at all?
There was a problem hiding this comment.
we do. in case the point isn't aligned to 4 bytes it will be aligned manually.
atuchin-m
force-pushed
the
flat-containter-builders
branch
from
690a3e5 to
352d7a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR introduces new structures to be used in cosmetic_filters: