Skip to content

Conversation

@Konstantinov-Innokentii

In case, when location objects and matching components are stored in array of objects like this:
let routes = [{location: Location, component: Component}, ...]

and used in this way:

<Switch location={createLocation(this.props.window.path+this.props.window.search)}>
    {routes.map(r => r.location.toRoute({
        render: (props) => <r.component {...props} />,
        invalid: NotFound,
    }))}
</Switch>

I get Warning "Each child in an array or iterator should have a unique "key" prop". To avoid it I should pass key prop to Route. For this purpose I added routeProps param to Location.toRoute().
Usage is:

<Switch location={createLocation(this.props.window.path+this.props.window.search)}>
    {routes.map(r => r.location.toRoute({
        render: (props) => <r.component {...props}/>,
        invalid: NotFound,
    },  true, {key: this.props.uuid}, false, false))}
</Switch>

@ptrobert
Copy link

ptrobert commented Apr 15, 2019

In case, when location objects and matching components are stored in array of objects like this:
let routes = [{location: Location, component: Component}, ...]

and used in this way:

<Switch location={createLocation(this.props.window.path+this.props.window.search)}>
    {routes.map(r => r.location.toRoute({
        render: (props) => <r.component {...props} />,
        invalid: NotFound,
    }))}
</Switch>

I get Warning "Each child in an array or iterator should have a unique "key" prop". To avoid it I should pass key prop to Route. For this purpose I added routeProps param to Location.toRoute().
Usage is:

<Switch location={createLocation(this.props.window.path+this.props.window.search)}>
    {routes.map(r => r.location.toRoute({
        render: (props) => <r.component {...props}/>,
        invalid: NotFound,
    },  true, {key: this.props.uuid}, false, false))}
</Switch>

Facing the same issue, Please merge this quickly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants