Skip to content

Drop deprecated functions withMap() and withFilter() #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2021
Merged

Drop deprecated functions withMap() and withFilter() #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions src/IterableObject.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,26 +79,6 @@ public function map($map)
return new self($this->iterable, $this->filter, $map);
}

/**
* @param callable $filter
* @return self
* @deprecated Use IterableObject::filter instead.
*/
public function withFilter($filter)
{
return $this->filter($filter);
}

/**
* @param callable $map
* @return self
* @deprecated Use IterableObject::map instead.
*/
public function withMap($map)
{
return $this->map($map);
}

/**
* @inheritdoc
*/
Expand Down
32 changes: 0 additions & 32 deletions tests/TestIterableObject.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,38 +43,6 @@ public function testFromTraversableToArray($data, $filter = null, $map = null, $
$this->assertEquals($expectedResult, $iterableObject->asArray());
}

public function testFilterMutator()
{
$filter = function ($value) {
return 'bar' === $value;
};
$iterableObject = iterable(array('foo', 'bar'))->withFilter($filter);
$this->assertEquals(array(1 => 'bar'), iterator_to_array($iterableObject));
}

public function testMapMutator()
{
$map = 'strtoupper';
$iterableObject = iterable(array('foo', 'bar'))->withMap($map);
$this->assertEquals(array('FOO', 'BAR'), iterator_to_array($iterableObject));
}

public function testFilterAndMapMutators()
{
$filter = function ($value) {
return 'bar' === $value;
};
$map = 'strtoupper';
$iterableObject = iterable(array('foo', 'bar'))->withMap($map)->withFilter($filter);
$this->assertEquals(array(1 => 'BAR'), iterator_to_array($iterableObject));
$iterableObject = iterable(array('foo', 'bar'))->map($map)->filter($filter);
$this->assertEquals(array(1 => 'BAR'), iterator_to_array($iterableObject));
$iterableObject = iterable(array('foo', 'bar'))->withFilter($filter)->withMap($map);
$this->assertEquals(array(1 => 'BAR'), iterator_to_array($iterableObject));
$iterableObject = iterable(array('foo', 'bar'))->filter($filter)->map($map);
$this->assertEquals(array(1 => 'BAR'), iterator_to_array($iterableObject));
}

public function dataProvider()
{
$data = array('foo', 'bar');
Expand Down