Properly handle boolean options in the fields_for
helper
#764
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes how boolean options (e.g.
inline_errors
) are handled in thefields_for
helper.Currently, option defaults are loaded in the helper using the following code:
This approach doesn't work for boolean options, because
false
evalues as falsy, even though it's a legitimate value. As a result, the option value is being overriden with a default value.For example, the code below does not work as indended (inline errors are still added to the City field):
In order to fix this, I changed:
to:
which is more verbose, but works corrently for boolean options.