Skip to content

Conversation

donv
Copy link
Collaborator

@donv donv commented Apr 28, 2022

For vertical layouts and a single check box, the form group should have a bottom margin.

@donv donv requested review from lcreid and thimo April 28, 2022 13:16
Copy link
Contributor

@lcreid lcreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this contribution.

@donv
Copy link
Collaborator Author

donv commented Apr 29, 2022

Thanks! I really like how we now can verify the change with a visual example 😄 .

@donv donv merged commit 7529f5d into main Apr 29, 2022
@donv donv deleted the add_margin_below_check_boxes branch April 29, 2022 04:36
@lcreid
Copy link
Contributor

lcreid commented Jun 27, 2025

@donv In hindsight, I don't think this was the right decision. There are lots of cases where someone might want invidiual check boxes to be spaced the same as radio buttons. Comgined with this issue, it becomes pretty hard to achieve the desired output.

However, given that this has been out there for three years, I don't want to just change back.

We've started to be able to define some configuration, and I've long wished we had a way to warn about changes to rendered output, and allow configuration based on version. What do you think if I look into ways to configure default behaviour, and warn about changes to defaults?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants