Skip to content

Conversation

mojca
Copy link

@mojca mojca commented Mar 16, 2023

When compiling in Visual Studio 2022 with "treat warnings as errors", I'm getting the following error which this PR should address. (The other option is to comment out the name.)

(I would be grateful if a fix could end up in 1.82.0.)

boost\libs\thread\src\win32\thread.cpp(580,236): error C2220: the following warning is treated as an error
boost\libs\thread\src\win32\thread.cpp(580,236): error C2220:             static inline BOOL WINAPI SetWaitableTimerEx_emulation(HANDLE hTimer, const LARGE_INTEGER *lpDueTime, LONG lPeriod, PTIMERAPCROUTINE pfnCompletionRoutine, LPVOID lpArgToCompletionRoutine, PREASON_CONTEXT WakeContext, ULONG TolerableDelay)
boost\libs\thread\src\win32\thread.cpp(580,236): error C2220:                                                                                                                                                                                                                                            ^
boost\libs\thread\src\win32\thread.cpp(580,236): warning C4100: 'TolerableDelay': unreferenced formal parameter
boost\libs\thread\src\win32\thread.cpp(580,217): warning C4100: 'WakeContext': unreferenced formal parameter
boost\libs\thread\src\win32\thread.cpp(580,217): warning C4100:             static inline BOOL WINAPI SetWaitableTimerEx_emulation(HANDLE hTimer, const LARGE_INTEGER *lpDueTime, LONG lPeriod, PTIMERAPCROUTINE pfnCompletionRoutine, LPVOID lpArgToCompletionRoutine, PREASON_CONTEXT WakeContext, ULONG TolerableDelay)
boost\libs\thread\src\win32\thread.cpp(580,217): warning C4100:                                                                                                                                                                                                                         ^

@mojca
Copy link
Author

mojca commented Apr 4, 2023

Is there any chance to review/merge this before the next Boost release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant