Compilation error in future.hpp using LLVM upstream clang

[thevinster]

After this patch in upstream LLVM, this line in future.hpp

thread/include/boost/thread/future.hpp

Line 4671 in aec18d3

that_=x.that;

fails to compile with the following error

boost/boost/thread/future.hpp:4672:19: error: no member named 'that' in 'run_it<FutureExecutorContinuationSharedState>'; did you mean 'that_'?
 4672 |           that_=x.that;
      |                   ^
boost/boost/thread/future.hpp:4650:55: note: 'that_' declared here
 4650 |     shared_ptr<FutureExecutorContinuationSharedState> that_;
      |                                                       ^

From looking at the error and the code surrounding the error, is this a bug in future.hpp where the code should be using x.that_ given other nearby uses of x.that_?

[DimitryAndric]

Yes, in my opinion it is a typo in boost. The line should read:

          that_=x.that_;

[arvid-norlander]

I'm having trouble figuring out which release of boost the fix is included with. Based on release date and the date of the commit that fixes this I would have expected that 1.86 has the fix, but there is nothing in the release notes about the thread library at all. So I guess it missed the deadline? And the code is still broken in 1.86 tar ball unfortunately.

Will there be a patch release with the fix?

[DimitryAndric]

As far as I can see, @zlojvavan only put this in a fork: zlojvavan@3f91512, so it won't be in any release tarball yet, I guess.

[arvid-norlander]

Ah I missed that detail.

[arvid-norlander]

Currently this breaks compilation with Clang 19, which has been released as of 2024-09-17. I believe it would make sense for boost to make a hotfix release of some sort to address this. Clang is after all one of the three big C++ implementations.