Make sure the i386 sysv stack is aligned #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix had a typo in which the wrong offset was used which meant that the alignment still wasn't correct. Fix this properly now.
nielsdos
added a commit
to nielsdos/php-src
that referenced
this pull request
Jan 28, 2023
Fixes phpGH-10398 The stack was misaligned upon entering the trampoline function [1], this causes a CPU trap when the SSE instruction is executed to copy data from the stack. This was fixed upstream [2]. This commit syncs all upstream changes from the boost/context assembly files to our copy. [1] php#10407 (comment) [2] boostorg/context#219
devnexen
pushed a commit
to php/php-src
that referenced
this pull request
Feb 5, 2023
Fixes GH-10398 The stack was misaligned upon entering the trampoline function [1], this causes a CPU trap when the SSE instruction is executed to copy data from the stack. This was fixed upstream [2]. This commit syncs all upstream changes from the boost/context assembly files to our copy. [1] #10407 (comment) [2] boostorg/context#219 Closes GH-10407.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix #218 had a typo in which the wrong offset was used which meant that the alignment still wasn't correct. Fix this properly now.
Sorry for this mistake, my testing didn't catch this because I set it up wrongly. This PR properly fixes the alignment and fixes the bug the original PR was meant to fix.