User interface flex #238
User interface flex #238
Conversation
| time, mark, audio, video { | ||
| margin: 0; | ||
| padding: 0; | ||
| margin: 20; |
There was a problem hiding this comment.
Adding properties to a bunch of elements/classes at once is really efficient and it's a good coding practice when there's a use for it,, but I do want to caution you to think carefully about inheritance when you assign them like this. Many properties are inherited, but some are not -- and if the code you're writing applies to nearly every element on the page, it can be hard to predict and troubleshoot the changes you're making.
| } | ||
|
|
||
| .container { | ||
| width: 880px; |
There was a problem hiding this comment.
Adding a width to the container is a great way to make a predictable layout that will look the same every time. As we move into responsive layouts, I encourage you to think about the pros and cons of a fixed-width content container versus a responsive layout (or even just a different CSS property, like adding margins to the container).
| display: flex; | ||
| flex-direction: row; | ||
| justify-content: flex-start; | ||
| justify-content: space-evenly; |
There was a problem hiding this comment.
It looks like you're assigning the justify-content property and then overwriting it on the next line. This shouldn't cause any problems while rendering, but it might be confusing to look at later on.
3 participants
Challenge #2