. #1
. #1
Conversation
|
. |
project1/css/index.css
Outdated
| color:gray; | ||
| text-decoration:none; | ||
| } | ||
| ul{ |
There was a problem hiding this comment.
Let's try to keep the spacing around the target element and curly brace consistent throughout the code. The way you want to write code is completely fine, and style suggestions are just that. But when writing code in your chosen style make sure to keep it consistent for nice clean code! :)
project1/css/index.css
Outdated
| position:relative; | ||
| top:8px; | ||
| } | ||
| li { |
There was a problem hiding this comment.
Same thing here- make sure you are either spacing or not spacing all of the target elements and their respective curly braces.
| height:100px; | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
Inconsistent spacing between different blocks of code. All of the code up to this point had no space between blocks.
Consistency is key!
|
Hi Darryl- just reviewed your code and have to say that it is really well done. The only issues that I saw were style inconsistencies - which will come with repeated practice. Great job on this! Keep up the good work! -Ray |
|
Please close this PR when read- thanks! |
|
Hey Darryl- just looked over your code and everything looks great. I like the constant commits and explicit commit messages. That's a great habit to get into. Good to see the consistent style throughout. Like I said before there is no right or wrong way to style your code, and what you've done now is great, but when working in a production environment make sure you adapt your style to the employer's needs. Great work! -Ray |
|
Please close this PR when read- thanks! |
ghost
closed this
Project completed with 3 stretch goals. bloominstituteoftechnology#1 h1, h2, and contact uses new font. bloominstituteoftechnology#2 locked nav bar on top with background color. bloominstituteoftechnology#3 nav bar hover changes nav item background color, font color, and font size. :wq :q :q q :q
Add styles for stretch goals bloominstituteoftechnology#1, bloominstituteoftechnology#2 and bloominstituteoftechnology#5
…anZiegenfus finished UI2 project
2 participants
The code only works on certain browser resolutions. If it's suppose to stay in position for all possible resolutions, please let me know and I'll attempt to fix it.