Run with Python 3 only #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We drop support for Python 2 which allows us to remove dependencies on `mock` and `six`. The minimum Python version is now specified in setup.py. Signed-off-by: Aidan Delaney <[email protected]> Signed-off-by: Kunal Mehta <[email protected]> Co-authored-by: Kunal Mehta <[email protected]>
Author
|
CI is failing because the black style has changed since - I can reformat it if you all want but also didn't want to add extra stuff in to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: this is a resubmission of #14
Describe your changes
We drop support for Python 2 which allows us to remove dependencies on
mockandsix. The minimum Python version is now specified in setup.py.Testing performed
I've done static review, will probably run it our CI setup shortly.
Additional context
As mentioned earlier, this is a resubmitted version of #14 to just focus on removing the Python 2 code/dependencies. I backed out the other functional changes so that the scope of this one is smaller and then rebased it against master.