enable configurable default node weight instead of hardcoded 128 #41
+232
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, managed hash rings always used a hardcoded weight of 128 for all nodes, preventing operators from tuning the ring's distribution characteristics. The number of virtual nodes (weight) affects distribution smoothness - higher weights create smoother distribution, while lower weights may create less uniform distribution. This change allows operators to configure a custom default weight via node_weight, enabling them to optimize for their specific requirement. The configured node_weight applies consistently to all nodes added without explicit weights: initial configuration nodes, automatically monitored nodes, and nodes added via the API without specifying a weight. Backward compatibility is maintained - node_weight defaults to 128 when not specified.
the tests uses clustering, which can be difficult to test in async
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, managed hash rings always used a hardcoded weight of 128 for all nodes, preventing operators from tuning the ring's distribution characteristics. The number of virtual nodes (weight) affects distribution smoothness - higher weights create smoother distribution, while lower weights may create less uniform distribution.
This change allows operators to configure a custom default weight via node_weight, enabling them to optimize for their specific requirement.
The configured node_weight applies consistently to all nodes added without explicit weights: initial configuration nodes, automatically monitored nodes, and nodes added via the API without specifying a weight.
Backward compatibility is maintained - node_weight defaults to 128 when not specified.