Skip to content

Added spaces to separate init commands when importing commands into s… #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Added spaces to separate init commands when importing commands into s… #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ Three sets of init commands are availiable as of version `1.1.0`:
### <a id="history"></a>History

```
v1.1.1 - 2020-12-07
- Fixed bug import of custom commands if provided for certificate based auth

v1.1.0 - 2020-12-03
- Added option for key and thumbprint based Exchange authentication

Expand Down
4 changes: 2 additions & 2 deletions o365Utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ module.exports.getO365PSKeyInitCommands = function (pathToDecryptUtilScript,
'$CertificatePassword = (ConvertTo-SecureString -String "' + authCertificatePassword + '" -AsPlainText -Force)',

// #6 connect to exchange
'Connect-ExchangeOnline -CertificateFilePath $CertificateFilePath -CertificatePassword $CertificatePassword -AppID ' + applicationId + ' -Organization ' + organizationId + psCommandsToImport,
'Connect-ExchangeOnline -CertificateFilePath $CertificateFilePath -CertificatePassword $CertificatePassword -AppID ' + applicationId + ' -Organization ' + organizationId + ' ' + psCommandsToImport,

// #7 cleanup
'Remove-Variable -Force -ErrorAction SilentlyContinue $PSCredential'
Expand Down Expand Up @@ -235,7 +235,7 @@ module.exports.getO365PSThumbprintInitCommands = function (pathToDecryptUtilScri
('$sessionOpt = New-PSSessionOption -OpenTimeout ' + openTimeout + ' -OperationTimeout ' + operationTimeout + ' -IdleTimeout ' + idleTimeout),

// #6 connect to exchange
'Connect-ExchangeOnline -CertificateThumbPrint ' + certificateThumbPrint + ' -AppID ' + applicationId + ' -Organization ' + organizationId + psCommandsToImport,
'Connect-ExchangeOnline -CertificateThumbPrint ' + certificateThumbPrint + ' -AppID ' + applicationId + ' -Organization ' + organizationId + ' ' + psCommandsToImport,

// #7 cleanup
'Remove-Variable -Force -ErrorAction SilentlyContinue $PSCredential'
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "powershell-command-executor",
"version": "1.1.0",
"version": "1.1.1",
"description": "Provides a registry and gateway for execution powershell commands through long-lived established remote PSSessions via a stateful-process-command-proxy pool of powershell processes",
"main": "psCommandService.js",
"directories": {
Expand All @@ -23,9 +23,9 @@
"exec"
],
"dependencies": {
"stateful-process-command-proxy": "latest",
"mustache": "^4.1.0",
"promise": "latest",
"mustache": "latest"
"stateful-process-command-proxy": "latest"
},
"devDependencies": {
"mocha": "latest"
Expand Down