Bugfix/246 batch list desc #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mesilov
requested changes
Sep 12, 2025
src/Core/Batch.php
Outdated
| // todo checked that sorting is set as "order": {"ID": "ASC"} i.e. the developer understands that the data will arrive in this order | ||
| // todo checked that if there is a limit, then it is >1 | ||
| // todo checked that there is no ID field in the filter, since we will work with it | ||
| // Determine sort direction and ID key |
Collaborator
There was a problem hiding this comment.
Add link to documentation with explanation for big cost for count operations
| /** | ||
| * Returns relative path to previous ID value | ||
| */ | ||
| protected function getReferenceFieldPath(string $prevCommandId, int $lastIndex, string $keyId, bool $isCrmItemsInBatch): string |
Collaborator
There was a problem hiding this comment.
Add to criteria for get traversableList support for id pointers in previous batch results
| /** | ||
| * Extracts elements from batch request result | ||
| */ | ||
| protected function extractElementsFromBatchResult(ResponseData $responseData, bool $isCrmItemsInBatch): array { |
Collaborator
There was a problem hiding this comment.
Add array shape type hints for result
mesilov
requested changes
Sep 12, 2025
| use PHPUnit\Framework\TestCase; | ||
| use Symfony\Component\Uid\Uuid; | ||
|
|
||
| #[CoversClass(Batch::class)] |
Collaborator
There was a problem hiding this comment.
Add test for
$result[request_id][response_field]
Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated in Core\Batch getTraversableList(), getTraversableListWithCount(); modified BatchOperationsInterface and unit-test NullBatch to be compatible with getTraversableListWithCount(). Added tests into tests/Integration/Core/BatchTraversableListTest.php
Additionally: