isHexa -> isHexaOrEmpty #3181
Closed
isHexa -> isHexaOrEmpty #3181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it's possible to
```
bitcore.crypto.Hash.sha256 (bitcore.util.buffer.hexToBuffer('')).toString ('hex');
```
that correctly produce
"e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"
instead of an assertion error.
This small change is quite invasive anyway, so I think that before being merged, it must be well tested.
isghe
added a commit
to isghe/bitcore
that referenced
this pull request
Jun 2, 2021
So it's possible to:
```
bitcore.util.buffer.hexToBuffer('').toString('hex');
```
that produce an empty string as expected,
instead od an assertion error.
This commit makes bitpay#3181 unnecessary.
|
#3182 makes this PR unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it's possible to
that correctly produce
"e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"
instead of an assertion error.
This small change is quite invasive anyway, so I think that before being merged, it must be well tested.