Improve sync and fix reorg #507
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 21, 2017 10:42
gabegattis
reviewed
Jun 21, 2017
| async.map(heights, function(height, next) { | ||
|
|
||
| if (height === 0) { | ||
| var block = new Block(self.bitcoind.genesisBuffer); |
Contributor
There was a problem hiding this comment.
with this removed, the require on line 9 is no longer used
Contributor
Author
There was a problem hiding this comment.
removed unnecessary require
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync uses a ReadStream. ReadStreams have their own built in queues. We shouldn't try to reinvent the wheel implementing our own queue. The ReadStream will add to its internal buffer by repeated calling _read() until the highWaterMark is met.
This PR also fixes reorg detection and finishes implementing the reorg integration test.