Skip to content

Volatile read LFU drain status #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Volatile read LFU drain status #512

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6808578
volatile
Nov 23, 2023
57ecc8e
Merge branch 'main' into users/alexpeck/volatile
bitfaster Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions BitFaster.Caching/Lfu/ConcurrentLfu.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ IEnumerator IEnumerable.GetEnumerator()

private void TryScheduleDrain()
{
if (this.drainStatus.NonVolatileRead() >= DrainStatus.ProcessingToIdle)
if (this.drainStatus.VolatileRead() >= DrainStatus.ProcessingToIdle)
{
return;
}
Expand Down Expand Up @@ -832,8 +832,6 @@ private bool AdmitCandidate(K candidateKey, K victimKey)
int victimFreq = this.cmSketch.EstimateFrequency(victimKey);
int candidateFreq = this.cmSketch.EstimateFrequency(candidateKey);

//var (victimFreq, candidateFreq) = this.cmSketch.EstimateFrequency(victimKey, candidateKey);

// TODO: random factor when candidate freq < 5
return candidateFreq > victimFreq;
}
Expand Down