Skip to content

Conversation

@bitfaster
Copy link
Owner

@bitfaster bitfaster commented Oct 24, 2023

Fixes a regression introduced in 2.3.0 when updating the ConcurrentLruCore.TryRemove methods.

This caused the dispose code path to fail when caching a null. Therefore, introduce a test for round tripping a null value through ConcurrentLru and ConcurrentLfu.

@bitfaster bitfaster changed the title Lru remove locks value instead of item Lru OnRemove locks value instead of item Oct 24, 2023
@coveralls
Copy link

coveralls commented Oct 24, 2023

Coverage Status

coverage: 98.517% (+0.1%) from 98.388% when pulling 5700be0 on users/alexpeck/rembug into 4d52e6f on main.

@bitfaster bitfaster merged commit 1a69acf into main Oct 24, 2023
@bitfaster bitfaster deleted the users/alexpeck/rembug branch October 24, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants