-
Notifications
You must be signed in to change notification settings - Fork 39
Align ICache.TryRemove overloads with ConcurrentDictionary #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 9, 2023
bitfaster
added a commit
that referenced
this pull request
Nov 13, 2023
Provide functional parity with ConcurrentDictionary for IAsyncCache.TryRemove, following the implementation for ICache in PR #394.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide functional parity with
ConcurrentDictionaryforICache.TryRemove.bool TryRemove(K key, out V value)andbool TryRemove(KeyValuePair<K,V> item)ConcurrentDictionary TryRemove(key, out value)forICache TryRemove(K key)andTryRemove(K key, out V value)to avoid double dictionary lookup then remove.TryRemove(KeyValuePair<K,V>)ICachedefault implementations for backwards compatibility throwNotSupportedException. There is no way to correctly implement either new method, so it is better to throw than give the caller an incorrect result. This would only apply if a caller implements ICache themselves, upgrades the library, and doesn't have impls for these methods.IEquatableto compare wrapped values. Values that are not yet created are always not equal, similar to comparing null.