unbounded #370
Merged
unbounded #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 15, 2023 16:52
Owner
Author
|
Verified hit rate analysis is approx the same (difference is noise), except for ARC OLTP which is around 1% better hit rate across the board. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unbounded LRU growth when keys are requested in order. Added better parameterized tests to detect this.
I had introduced a bug in the cycle/tryremovecold method: when warm queue is full the last cold item should be discarded immediately.
When cache size is below 1000, element count is now constrained to capacity +1 (we allow warm queue to be capacity+1, enabling items to re-enter warm). When cache size is above 1000, element count is constrained to at worst capacity + 5. Experimentally, this matches the number of cycle attempts (which is currently 5). This is a bug that results in at most a 0.5% capacity overage, so much better than prior to the fix.