Skip to content

fix(ci): code coverage actions/upload-artifact version #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 7, 2024
Merged

fix(ci): code coverage actions/upload-artifact version #96

merged 4 commits into from
Sep 7, 2024

Conversation

@oleonardolima
Copy link
Collaborator

@oleonardolima oleonardolima commented Sep 4, 2024

Description

The Code Coverage step seems to start failing due to actions/checkout@v2 becoming deprecated, and an error now instead of a warning. At least it's what I got from the error message here: https://github.com/bitcoindevkit/rust-esplora-client/actions/runs/10702593999/job/29671147653?pr=93

This PR bumps it's version to v4, the latest one. I'm also taking the opportunity to bump the action/checkout to v4 too.

I'm not sure if it became fully/enforced deprecation from yesterday to today, because it ran successfully on the last master merged PR CI steps #:thinking:

Notes to the reviewers

Please let me know if I should take the opportunity to bump any other actions, or update the workflow in any way.

Changelog notice

  • Bump actions/upload-artifact to v4.
  • Bump actions/checkout to v4.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@oleonardolima oleonardolima self-assigned this Sep 4, 2024
@oleonardolima oleonardolima added the ci Continuous Integration issues label Sep 4, 2024
@oleonardolima oleonardolima mentioned this pull request Sep 4, 2024
Merged
3 tasks
@ValuedMammal
Copy link
Contributor

ValuedMammal commented Sep 4, 2024

This looks good to me, seems like the workflow was in need of an update. I noticed it's also installing rust via sh.rustup.rs which is interesting considering we typically use another github action for that

@oleonardolima
Copy link
Collaborator Author

oleonardolima commented Sep 4, 2024

This looks good to me, seems like the workflow was in need of an update. I noticed it's also installing rust via sh.rustup.rs which is interesting considering we typically use another github action for that

Oh, you're right. I'll update it to the same one as the other CI jobs.

@oleonardolima oleonardolima force-pushed the fix/ci-code-coverage-upload-artifact-action branch 2 times, most recently from 7b5b4b1 to 8608109 Compare September 4, 2024 16:20
@coveralls
Copy link

coveralls commented Sep 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10723811847

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.438%
Totals Coverage Status
Change from base Build 10690950735: 0.0%
Covered Lines: 1058
Relevant Lines: 1210
💛 - Coveralls

@oleonardolima oleonardolima marked this pull request as ready for review September 4, 2024 17:28
ValuedMammal
ValuedMammal approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8608109

tnull
tnull reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, mod one comment

.github/workflows/code_coverage.yml Outdated
- name: Set default toolchain
run: rustup default nightly
- name: Install Rust Toolchain
uses: dtolnay/rust-toolchain@v1
Copy link
Contributor

@tnull tnull Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change necessary? IIUC, it should do the same thing, but introduces another (unnecessary) dependency to the CI? IMO, the previous way was preferable (and saves the addtional rustup update step later on).

Copy link
Collaborator Author

@oleonardolima oleonardolima Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not really necessary. I just used the opportunity to update it to use the same toolchain action used on our other CIs.

I have no big feelings about dropping the e404089 if you folks see fit :)

Copy link
Contributor

@ValuedMammal ValuedMammal Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no big feelings about dropping the e404089 if you folks see fit :)

Sounds good, I guess tnull is right

Copy link
Collaborator Author

@oleonardolima oleonardolima Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I removed the e404089 commit and rebased it on top of master.

Copy link
Collaborator Author

@oleonardolima oleonardolima Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a new commit 7321a5d to fix the tokio-util MSRV problem.

@oleonardolima oleonardolima force-pushed the fix/ci-code-coverage-upload-artifact-action branch from 8608109 to cec57f6 Compare September 5, 2024 15:39
evanlinjin
evanlinjin approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7321a5d

@ValuedMammal
Copy link
Contributor

ValuedMammal commented Sep 7, 2024

ACK 7321a5d

@ValuedMammal ValuedMammal merged commit 53db518 into bitcoindevkit:master Sep 7, 2024
@oleonardolima oleonardolima deleted the fix/ci-code-coverage-upload-artifact-action branch September 9, 2024 17:52
chrono-raven6i90 added a commit to chrono-raven6i90/rust-esplora-client that referenced this pull request Oct 28, 2025
@chrono-raven6i90
Merge bitcoindevkit/rust-esplora-client#96: fix(ci): code coverage `a…
13747d1 
…ctions/upload-artifact` version

7321a5dd578ebc77d33cdd8b55d2948d9fcf1162 fix(ci): pin `tokio-util` to `0.7.11` (Leonardo Lima)
cec57f64f2b3dcee895854d61747fd3462604fc3 chore: remove bdk repository related comment (Leonardo Lima)
33a6f211fcba01bedd909475494454ee60895e50 deps(ci): bump `actions/checkout` to `v4` (Leonardo Lima)
b22d95ff904f6569ffd8ecbf96b76bfbcb1532ff deps(ci): bump `actions/upload-artifact` to `v4` (Leonardo Lima)

Pull request description:

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description

  The Code Coverage step seems to start failing due to `actions/checkout@v2` becoming deprecated, and an error now instead of a warning. At least it's what I got from the error message here: https://github.com/bitcoindevkit/rust-esplora-client/actions/runs/10702593999/job/29671147653?pr=93

  This PR bumps it's version to `v4`, the latest one. I'm also taking the opportunity to bump the `action/checkout` to `v4` too.

  I'm not sure if it became fully/enforced deprecation from yesterday to today, because it ran successfully on the last master merged PR CI steps #:thinking:

  <!-- Describe the purpose of this PR, what's being adding and/or fixed -->

  ### Notes to the reviewers

  Please let me know if I should take the opportunity to bump any other actions, or update the workflow in any way.

  <!-- In this section you can include notes directed to the reviewers, like explaining why some parts
  of the PR were done in a specific way -->

  ### Changelog notice

  - Bump `actions/upload-artifact` to `v4`.
  - Bump `actions/checkout` to `v4`.

  <!-- Notice the release manager should include in the release tag message changelog -->
  <!-- See https://keepachangelog.com/en/1.0.0/ for examples -->

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  ValuedMammal:
    ACK 7321a5dd578ebc77d33cdd8b55d2948d9fcf1162
  evanlinjin:
    ACK 7321a5dd578ebc77d33cdd8b55d2948d9fcf1162

Tree-SHA512: ac00626633fdfad2cca88e971fa953c71ed3363b68a87351677d0737891eca782c08705ec355c00778211024bcc28791adb66c1e17a5f8d2487fd601a75965de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ValuedMammal ValuedMammal ValuedMammal approved these changes

@evanlinjin evanlinjin evanlinjin approved these changes

@notmandatory notmandatory Awaiting requested review from notmandatory

+1 more reviewer

@tnull tnull tnull approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@oleonardolima oleonardolima

Labels

ci Continuous Integration issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@oleonardolima @ValuedMammal @coveralls @tnull @evanlinjin