-
Notifications
You must be signed in to change notification settings - Fork 68
feat: add way to make raw req and get url for BlockingClient
#87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add way to make raw req and get url for BlockingClient
#87
Conversation
Pull Request Test Coverage Report for Build 9525108942Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9525267064Details
💛 - Coveralls |
notmandatory
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK f3c0055
Also add `size` and `weight` fields to `Tx`.
f3c0055 to
3b778c5
Compare
evanlinjin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self-ACK 3b778c5
Pull Request Test Coverage Report for Build 9528664736Details
💛 - Coveralls |
oleonardolima
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
post-merge ACK 3b778c5
It just seems that it requires some dependency pinning for the MSRV
|
Oh ya CI is broken, same issue as on the BDK branch. I'll make a new PR to fix it. |
Thanks! I didn't notice that it was the same problem as bitcoindevkit/bdk#1470 |
… req and get url for `BlockingClient`
3b778c57625ab8f4fb9b72b4e2013af74045a846 feat: add method for getting tx info via `GET /tx/:txid` (志宇)
bc3d431730052ace9766b328df2faae830c67062 feat: add way to make raw req and get url for `BlockingClient` (志宇)
Pull request description:
Also add method for getting from `/tx/:txid` endpoint.
ACKs for top commit:
evanlinjin:
self-ACK 3b778c57625ab8f4fb9b72b4e2013af74045a846
Tree-SHA512: 81ab7af85b40fba0ec20194649d2f95b8e5fcd66c856ffb1d10ab9f81cddbfd11ef6ff399bd542e7b920a426ccbd9c114152ebd170bc8e6b3562b44e16ce612d
Also add method for getting from
/tx/:txidendpoint.