Propagate errors from Esplora backends #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirfomene
force-pushed
the
expose_electrum_errors
branch
from
1170f15 to
abe1071
Compare
vladimirfomene
force-pushed
the
expose_electrum_errors
branch
25 times, most recently
from
e92ea4d to
604bca6
Compare
vladimirfomene
force-pushed
the
expose_electrum_errors
branch
12 times, most recently
from
39ec52f to
bf2b0c2
Compare
notmandatory
approved these changes
Sep 30, 2023
Member
notmandatory
left a comment
notmandatory
left a comment
There was a problem hiding this comment.
ACK bf2b0c2
Looks good, just one comment that should be cleaned up before merging.
realeinherjar
approved these changes
Oct 1, 2023
realeinherjar
left a comment
realeinherjar
left a comment
There was a problem hiding this comment.
ACK bf2b0c2
Great job. Just remove the println! as @notmandatory suggested.
vladimirfomene
force-pushed
the
expose_electrum_errors
branch
from
bf2b0c2 to
76dc3ae
Compare
Pull Request Test Coverage Report for Build 6377746375Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
chrono-raven6i90
added a commit
to chrono-raven6i90/rust-esplora-client
that referenced
this pull request
Oct 28, 2025
…lora backends 76dc3aed5d611a141ee37d0a7718fea82e530a17 doc: add note for MSRV to README (Vladimir Fomene) 48ee09f592343b140785f0316215b0f3870a4678 test: propagate errors to users (Vladimir Fomene) a1fadb06d6b8feebdb39f296b4334589f4c80b14 chore: remove ampersand on pinned dependencies line (Vladimir Fomene) fef4a776e9ce6c51bfbfd30f6b5ad4048ab64c5b Expose error message for Async client (Vladimir Fomene) 8d974ff4bbd449c28a9599807ffa7a07b5692310 Expose error message in addition to status in Blocking client (remix7531) Pull request description: Quick fix for #47 Top commit has no ACKs. Tree-SHA512: eeea5bebcb1d835015ef735e489eb85280e3cf36fa7e576dbe2d85970fffa5ec11c4065279ac5ba841dbb2f7cb29d64f8b12c6fa8eb2a1a8586b45bdbb2587e5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for #47