Skip to content

Conversation

@notmandatory
Copy link
Member

@notmandatory notmandatory commented Jul 18, 2025

Reverts #277

Per discussion on team chat yesterday we need to revert this since it's a breaking change and wasn't meant to be merged until the 3.0 milestone. ValuedMammal will have to re-submit a replacement PR.

@notmandatory notmandatory self-assigned this Jul 18, 2025
@notmandatory notmandatory moved this to Needs Review in BDK Wallet Jul 18, 2025
@notmandatory notmandatory added this to the Wallet 2.1.0 milestone Jul 18, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 16378824823

Details

  • 4 of 9 (44.44%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 84.733%

Changes Missing Coverage Covered Lines Changed/Added Lines %
wallet/src/wallet/persisted.rs 0 2 0.0%
wallet/src/wallet/mod.rs 4 7 57.14%
Files with Coverage Reduction New Missed Lines %
wallet/src/wallet/mod.rs 1 81.03%
Totals Coverage Status
Change from base Build 16352857078: 0.04%
Covered Lines: 6577
Relevant Lines: 7762

💛 - Coveralls

@notmandatory notmandatory added the chore Non-coding related work label Jul 18, 2025
Copy link
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 14d6a62

@notmandatory notmandatory merged commit 27899da into master Jul 19, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Wallet Jul 19, 2025
@notmandatory notmandatory deleted the revert-277-fix/clippy-lints branch September 24, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Non-coding related work

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants