Skip to content

feat(test-utils)!: use bitcoin::Amount instead of u64 on tests #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

feat(test-utils)!: use bitcoin::Amount instead of u64 on tests #223

merged 1 commit into from
May 28, 2025

Conversation

@luisschwab
Copy link
Member

@luisschwab luisschwab commented Apr 30, 2025

Description

This PR simply updates tests to use bitcoin::Amount instead of u64.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@coveralls
Copy link

coveralls commented Apr 30, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 15303847386

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.349%
Totals Coverage Status
Change from base Build 15303441301: 0.0%
Covered Lines: 7276
Relevant Lines: 8525
💛 - Coveralls

oleonardolima
oleonardolima reviewed May 5, 2025
View reviewed changes
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 114a94a

@ValuedMammal ValuedMammal added the api A breaking API change label May 7, 2025
@ValuedMammal ValuedMammal added this to the Wallet 2.0.0 milestone May 7, 2025
@ValuedMammal ValuedMammal moved this to Needs Review in BDK Wallet May 7, 2025
@ValuedMammal ValuedMammal added the tests New or improved tests label May 7, 2025
oleonardolima
oleonardolima approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 820a3a0

@luisschwab
Copy link
Member Author

luisschwab commented May 20, 2025

Rebased to trigger CI with the new ARM jobs.

@luisschwab
Copy link
Member Author

luisschwab commented May 20, 2025

Now CI is happy again.

@luisschwab luisschwab requested a review from notmandatory May 21, 2025 15:54
ValuedMammal
ValuedMammal approved these changes May 22, 2025
View reviewed changes
Copy link
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK bf0a8b0

@ValuedMammal ValuedMammal changed the title chore: use bitcoin::Amount instead of u64 on tests feat(test-utils)!: use bitcoin::Amount instead of u64 on tests May 22, 2025
@ValuedMammal
Copy link
Collaborator

ValuedMammal commented May 22, 2025

@luisschwab I changed the PR title to denote that this is an API change in the test_utils module.

notmandatory
notmandatory approved these changes May 22, 2025
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bf0a8b0

@ValuedMammal
Copy link
Collaborator

ValuedMammal commented May 28, 2025

reACK 104a301

@ValuedMammal ValuedMammal merged commit 54d4028 into bitcoindevkit:master May 28, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Wallet May 28, 2025
@luisschwab luisschwab deleted the chore/use-amount branch September 22, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@notmandatory notmandatory notmandatory approved these changes

@oleonardolima oleonardolima oleonardolima approved these changes

@ValuedMammal ValuedMammal ValuedMammal approved these changes

Assignees

@luisschwab luisschwab

Labels

api A breaking API change tests New or improved tests

Projects

BDK Wallet
Archived in project

Milestone

Wallet 2.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@luisschwab @coveralls @ValuedMammal @notmandatory @oleonardolima