-
Notifications
You must be signed in to change notification settings - Fork 46
deps!: update bdk_chain to 0.22.0
#208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps!: update bdk_chain to 0.22.0
#208
Conversation
Pull Request Test Coverage Report for Build 14905703496Details
💛 - Coveralls |
|
Why is this part of the 1.3 milestone and not 2.0? |
|
I renamed the old milestones so had to put this one back on the new 2.0. |
2fceda8 to
a60d70d
Compare
bdk at revision b7075865bdk at revision 4fe121e7
bdk at revision 4fe121e7bdk_chain to 4fe121e7
c83afda to
c2d27c0
Compare
`once_cell` remains pinned to 1.20.3
c2d27c0 to
a247215
Compare
bdk_chain to 4fe121e7bdk_chain to 0.22.0
|
I added a commit to expose the
I think this could be done in a follow up PR. |
evanlinjin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a small nit.
Also, I think we could also include eviction logic in example_wallet_rpc. I've done so in 4a52074
3c5fa0b to
e125014
Compare
|
Thanks @evanlinjin |
notmandatory
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK e125014
This PR updates
bdk_chaindependency to the latest version 0.22.0Notes to the reviewers
This PR doesn't make use of
CanonicalizationParamsfor any advanced use cases - instead we rely on the default params for all tx-graph queries.fixes #202
fixes #224
Changelog notice
bdk_chainto 0.22.0bdk_file_storeto 0.20.0Added
start_sync_with_revealed_spks_atstart_full_scan_atapply_evicted_txsChanged
start_sync_with_revealed_spksis feature gated by "std", as it uses the system time to provide the time of the sync and also the tx last-seen.apply_updateno longer requires std, as the timestamp is provided in the sync / full scan requeststart_full_scanis also gated behind "std"start_sync_*now includes the expected SPK history (vialist_expected_spk_txids)Removed
apply_update_atBREAKING
bdk_core::TxUpdateis non-exhaustive Make full-scan/sync flow easier to reason about. bdk#1838FileStoreErroris changed to hold a new inner type Refactor file store bdk#1684Changes to persisted data
The
tx_graph::ChangeSetgained a new default-able fieldlast_evictedto persist the fact that a tx is no longer part of the canonical chain.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing