Skip to content

Conversation

murchandamus
Copy link
Contributor

Renames the “Created” header to “Assigned” to better reflect the meaning of the date held in this header field.

@murchandamus murchandamus mentioned this pull request Sep 16, 2025
6 tasks
@ajtowns
Copy link
Contributor

ajtowns commented Sep 16, 2025

Sounds good, ack.

Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bip-0003.md Outdated
Status: <Draft | Complete | Deployed | Closed>
Type: <Specification | Informational | Process>
Created: <Date of number assignment (yyyy-mm-dd), or "?">
Assigned: <Date of number assignment (yyyy-mm-dd), or "?">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, this is described in line 149 below, but it costs only two words here to make the prescribed values clear at first glance without searching for further context

Suggested change
Assigned: <Date of number assignment (yyyy-mm-dd), or "?">
Assigned: <Date of number assignment (yyyy-mm-dd), or "?" before assignment>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it also be acceptable (or preferable) to leave no value prior to assignment? e.g. Assigned:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that scripts/buildtable.pl will need to be updated when this change is made across the BIPs.

Copy link
Contributor Author

@murchandamus murchandamus Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will be adding that to #1820.

Would it also be acceptable (or preferable) to leave no value prior to assignment? e.g. Assigned:

I think I would prefer it to have a value, but the preference is weakly held.

@murchandamus murchandamus force-pushed the 2025-09-assigned-header branch from a5d0e70 to b5406d5 Compare September 18, 2025 03:11
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, couple nits


## Rationale

[^assigned]: **Why was the Created header renamed to Assigned?**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[^assigned]: **Why was the Created header renamed to Assigned?**
[^assigned]: **Why was the Created header renamed to Assigned?**

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double space at the end of a line is markdown for linebreak, which puts the response on a separate line from the question.

@murchandamus murchandamus force-pushed the 2025-09-assigned-header branch from b5406d5 to ff05143 Compare September 18, 2025 19:48
@murchandamus murchandamus force-pushed the 2025-09-assigned-header branch from ff05143 to d784719 Compare September 18, 2025 19:50
@murchandamus
Copy link
Contributor Author

@jonatack, @ajtowns: I have addressed all comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants