-
Notifications
You must be signed in to change notification settings - Fork 5.7k
BIP3: Rename Created to Assigned #1970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Sounds good, ack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bip-0003.md
Outdated
Status: <Draft | Complete | Deployed | Closed> | ||
Type: <Specification | Informational | Process> | ||
Created: <Date of number assignment (yyyy-mm-dd), or "?"> | ||
Assigned: <Date of number assignment (yyyy-mm-dd), or "?"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, this is described in line 149 below, but it costs only two words here to make the prescribed values clear at first glance without searching for further context
Assigned: <Date of number assignment (yyyy-mm-dd), or "?"> | |
Assigned: <Date of number assignment (yyyy-mm-dd), or "?" before assignment> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it also be acceptable (or preferable) to leave no value prior to assignment? e.g. Assigned:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that scripts/buildtable.pl
will need to be updated when this change is made across the BIPs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I will be adding that to #1820.
Would it also be acceptable (or preferable) to leave no value prior to assignment? e.g.
Assigned:
I think I would prefer it to have a value, but the preference is weakly held.
a5d0e70
to
b5406d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, couple nits
|
||
## Rationale | ||
|
||
[^assigned]: **Why was the Created header renamed to Assigned?** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[^assigned]: **Why was the Created header renamed to Assigned?** | |
[^assigned]: **Why was the Created header renamed to Assigned?** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double space at the end of a line is markdown for linebreak, which puts the response on a separate line from the question.
b5406d5
to
ff05143
Compare
ff05143
to
d784719
Compare
Renames the “Created” header to “Assigned” to better reflect the meaning of the date held in this header field.