Skip to content

New SVG, Icons, PNGs and X PixMaps #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

1BitcoinBoWP1FZ4xwTNkq6XksKidmgYYw

This PR clean up the old SVG, Icons, PNGs and X PixMaps by providing optimized much smaller file size versions while at the same time keeping resolutions untouched. Shadows are removed from the files.

This PR clean up the old SVG, Icons, PNGs and X PixMaps by providing optimized much smaller file size versions while at the same time keeping resolutions untouched.
Shadows are removed from the files.
@DrahtBot
Copy link
Contributor

DrahtBot commented Jul 10, 2025

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
Concept NACK hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #852 (Updated MacOS icon to more closely fit Apple's design standards by rhysbeynon)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@hebasto
Copy link
Member

hebasto commented Jul 10, 2025

Shadows are removed from the files.

Why do you think this change is necessary?

Also, the size of the logo has been increased. Could you please mention this in the PR description as well, along with a justification for the change?

@1BitcoinBoWP1FZ4xwTNkq6XksKidmgYYw

This comment was marked as abuse.

@hebasto
Copy link
Member

hebasto commented Jul 10, 2025

GitHub renders chnages as follows:

image

... only the margins have been removed.

Why?

The shadows were removed to match the original Bitcoin logo from bitboy, which also did not include shadows.

Bitcoin Core has its own logo for years. I don't see your reference as a justification for this change.

Since users may download the Bitcoin logo (example the SVG version) directly from Bitcoin Core's source code, this ensures they receive properly optimized logo files.

I believe this constitutes a misuse of the Bitcoin Core codebase.

@1BitcoinBoWP1FZ4xwTNkq6XksKidmgYYw

This comment was marked as abuse.

@hebasto
Copy link
Member

hebasto commented Jul 11, 2025

Why?

Padding (not margin) has been removed because it is unnecessary and visually disruptive. Padding serves no purpose and only worsens the layout.

Not being a designer, these claims seem like a matter of taste to me. It would be helpful to hear other designers' opinions.

Bitcoin Core has its own logo for years. I don't see your reference as a justification for this change.

I discussed this PR with @jonasschnelli on IRC a few days ago. As the creator of the original logo files, he understands the rationale behind replacing them.

I have deep respect for @jonasschnelli, but PR discussions should not be based on someone's personal opinion without supporting reasoning.

I believe this constitutes a misuse of the Bitcoin Core codebase.

This assumption is incorrect. Users seeking the Bitcoin logo will specifically want Bitcoin Core's canonical bitcoin.svg file, not alternative versions.

That sounds at least controversial. If that were true, the current logos wouldn’t have been merged in the first place.

@jonasschnelli
Copy link
Contributor

I briefly discussed the issue of copyright and authorship on the SVG with the PR author in #bitcoin (IRC).

It sounded to me that the PR author was worried about the copyright and MIT licensing as well as who was the original designer. Unclear what the intention of this PR is as this also changes the copyright in the file.

I have no opinion on visual style.

@1BitcoinBoWP1FZ4xwTNkq6XksKidmgYYw

This comment was marked as abuse.

@hebasto
Copy link
Member

hebasto commented Jul 11, 2025

The goal of this PR is not just to correct the licensing information ...

Please update the PR description accordingly.

Given that the current files are 12–13 years old, it’s time for an update.

That’s not a justification for the changes, neither from a technical perspective nor a design one.

NACK from me.

@fanquake
Copy link
Member

@1BitcoinBoWP1FZ4xwTNkq6XksKidmgYYw that kind of commentary is unacceptable.

@fanquake fanquake closed this Jul 11, 2025
@bitcoin-core bitcoin-core locked and limited conversation to collaborators Jul 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants