Prism fixes #17
Merged
Prism fixes #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 27, 2018 19:04
…ht html template strings
This was referenced Feb 28, 2018
christopherjbaker
force-pushed
the
prism
branch
from
052a618 to
5bf1dd6
Compare
christopherjbaker
force-pushed
the
prism
branch
from
5bf1dd6 to
f9ba9b4
Compare
added 2 commits
February 27, 2018 20:19
added 18 commits
February 28, 2018 17:56
justinbmeyer
reviewed
Mar 2, 2018
prettify.js
Outdated
|
|
||
| require("./prism-config"); | ||
| var Prism = require("prismjs"); | ||
| require("prismjs/plugins/line-numbers/prism-line-numbers.js"); |
Member
There was a problem hiding this comment.
generally w/ steal, you don't include the .js
justinbmeyer
reviewed
Mar 2, 2018
prettify.js
Outdated
| * @return {Element|undefined} | ||
| */ | ||
| module.exports = function(){ | ||
| Prism.plugins.lineNumbers.getLine = function (element, number) { |
Member
There was a problem hiding this comment.
can you add some docs explaining this?
Author
There was a problem hiding this comment.
there was a bit, but I added more to the docblock above. also, this has been moved to bit-docs-html-highlight-line
justinbmeyer
approved these changes
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes canjs/canjs#3447