fix: Added custom 404 error page to app-demo nginx conf ... #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Added custom 404 error page to app-demo nginx conf with server details removed.
The app-demo service provides a trivial web-page that redirects to https://www.bit-broker.io/docs/getting-started/demo/
However, because the k8s deployment maps this to / (e.g. demo.bit-broker.io), any access to /some/invalid/path gets handled by this service, for which nginx will 404. This was configured to use the default nginx error message which includes basic server version info.
To address this, a custom 404 error page has been added & enabled which removes any server info.
NB nginx is still returning a server header, the version info has been disabled, but it's non-trivial (i.e. requires a 3rd party module) to strip the Server header completely e.g. per https://www.getpagespeed.com/server-setup/nginx/how-to-remove-the-server-header-in-nginx