-
Notifications
You must be signed in to change notification settings - Fork 51
feat(promotions): PROMO-1064 Add shipping discount action #1100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jpajar
wants to merge
2
commits into
main
Choose a base branch
from
PROMO-1064_2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a494217
to
e73d166
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
PROMO-1050 Add as_total field to shipping discount action PROMO-1050 Remove as_total field from shipping discount action PROMO-1050 Restrict count of shipping method IDs to 250 PROMO-1050 Add ShippingDiscountAction as valid action
bc-terra
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROMO-1064
What changed?
Updated the swagger for promotions, to include ShippingDiscountAction
Updated the overview, ensuring the new shipping discount action is covered
Updated Shipping Promotion Code Samples
Shipping Example

Request:
Response:

Promotion Overview:
Release notes draft
Anything else?
ping {names}