Skip to content

Mark order_taxes.tax_rate_id as deprecated, document sales_tax_id #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025

Conversation

theromulans
Copy link
Contributor

@theromulans theromulans commented Aug 7, 2025

TAX-2463

What changed?

  • Mark order_taxes.tax_rate_id as deprecated.
  • Document order_taxes.sales_tax_id (this has actually actually been in the response for a while now).

Release notes draft

  • To support a wider range of use cases, the order_taxes.tax_rate_id (int) is now deprecated and will be removed in the near future. Please update to use the order_taxes.sales_tax_id (string) field.

benpratt77
benpratt77 previously approved these changes Aug 7, 2025
@theromulans
Copy link
Contributor Author

theromulans commented Aug 7, 2025

@TomA-R (When you are back from holiday) I notice that I can't easily tag @bigcommerce/team-shipping or @bigcommerce/team-tax or @bigcommerce/team-orders as a reviewer in this repo. Is that something you could help resolve? I know we repeatedly face this issue, so (as last time) curious if there is a better way to get teams more accessible across a wider range of repos 🙏 Cheers.

Screenshot 2025-08-07 at 4 41 57 pm

@theromulans theromulans requested a review from a team August 7, 2025 06:42
@TomA-R
Copy link
Member

TomA-R commented Aug 7, 2025

hey @theromulans I've added the appropriate teams to this repository, will discuss the context on Slack

declankirk
declankirk previously approved these changes Aug 7, 2025
@theromulans theromulans merged commit 3f3bcdb into main Aug 11, 2025
3 checks passed
@theromulans theromulans deleted the tax-2463 branch August 11, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants