-
Notifications
You must be signed in to change notification settings - Fork 51
docs(orders: DEVDOCS-6459 improve dev docs for sideloading order cons… #1026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
reference/orders.v2.oas2.yml
Outdated
* `consignments` - include the response returned from the request to the `/orders/{order_id}/consignments` endpoint. You should also specify `consignment_structure=object` as a request parameter when including consignments. The default array structure provided is legacy and may not be supported in the future. | ||
* `consignments.line_items` - include the response returned from the request to the `/orders/{order_id}/products` endpoint in consignments. This implies `include=consignments`. You should also specify `consignment_structure=object` as a request parameter when including consignments. The default array structure provided is legacy and will be removed in the future. | ||
* `consignments` - include the response returned from the request to the `/orders/{order_id}/consignments` endpoint. Current default array structure is legacy and will be deprecated from **1 Feb 2026**. Specify `consignment_structure=object` as a request parameter when including consignments. | ||
* `consignments.line_items` - include the response returned from the request to the `/orders/{order_id}/products` endpoint in consignments. This implies `include=consignments`. Current default array structure is legacy and will be deprecated from **1 Feb 2026**. Specify `consignment_structure=object` as a request parameter when including consignments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍹 We might want to clear up the language around "This implies include=consignments
".
I'm not sure if it means that consignments.line_items
is considered as being a superset of consignments
(line_items
alone is the same as having both) or requiring consignments
to be part of the include
param in order for line_items
to function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @matt-evangelidis, did you have any alternative wording in mind for this?
Maybe something like:
- This will also includes the resources associated with
include=consignments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, @BC-SEven, that's just fine and clarifies exactly the question I had.
5422ff2
to
622b8d8
Compare
…ignments
[DEVDOCS-6459 ]
What changed?
Release notes draft
Anything else?
ping @bigcommerce/team-orders