MultiPoTranslationHttpLoader #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that loads translation files from paths and merge them
|
Please, my organization is holding on this. Could anyone have a quick look? |
|
I love this one! Hope it will be merged! |
|
@RignonNoel in the meantime, I had to publish the package in order to unblock my team. Feel free to use it, it is public. |
|
@sergiojoker11 Thanks! I will wait a little bit since this feature is not an urgency for me but i will definitively use it in the future. It's really more easy to understand for translators if files are splitted! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract an abstract class with common functionality.
Create a loader that loads from n-translation files and merge the translations.
In case of key collision, the last resource passed in (its translations) has more priority. Thus, the developer still has the control on priorities.
The existing TranslatePoHttpLoader functionality is untouched.
This allows to keep your translations organised (per module/library in subfolders) within the main application. (Some organization might want to keep the translations centralised).
Potential/desired improvement
Merge strategies.