This repository was archived by the owner on Feb 7, 2024. It is now read-only.
Support and test PHP 8.0 #695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so the tests would pass for PHP 8.0 in Windows.
Closed
|
It looks good to me. 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to at least test and see if PHP 8.0 would work with the existing codebase.
This is for the issue #639 about PHP 8.0. It is mentioned there that 2.x will have PHP 8.0 support, but it's only in beta and has been so for at least 5 months. Also having to upgrade to it means having to deal with potentially breaking changes which don't even seem to be listed anywhere, assuming there are breaking changes.
Also there was a PR for PHP 8.0 support for version 1.x (#659), but unlike there, here I make the change to the CI config as well to test in PHP 8.0.