Skip to content
This repository was archived by the owner on Feb 7, 2024. It is now read-only.

Conversation

stayallive
Copy link
Contributor

@stayallive stayallive commented Sep 15, 2020

I know 2.x is under way but it would be nice to have 1.x in a working state and this is quite the bug 😄

What is happening?
Presence channels are double counting unique users because it's counting socket ID's.

How does Pusher handle this?
Pusher uses the user_id property to uniquely count the users in a presence channel.

Does this PR fix that?
Well, yes 😉

Okay, so why are the tests failing?
See: #528.

Would be great to see this released on 1.x.

@rennokki rennokki merged commit 2ae00be into beyondcode:master Sep 15, 2020
@stayallive stayallive deleted the feature/fix-presence-channels branch September 15, 2020 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants