Skip to content

Replace system #21368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace system #21368

wants to merge 2 commits into from
+77 −2

Conversation

hymm
Copy link
Contributor

@hymm hymm commented Oct 3, 2025

Objective

  • Allow replacing a system. Hopefully useful for hot reloading.

Solution

  • Replace the inner SystemWithAccess, which holds both the boxed system and the component access.

Testing

  • Just the one unit test

@dloukadakis dloukadakis added A-ECS Entities, components, systems, and events S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 3, 2025
alice-i-cecile
alice-i-cecile reviewed Oct 3, 2025
View reviewed changes
crates/bevy_ecs/src/schedule/node.rs
key
}

pub(crate) fn replace(&mut self, key: SystemKey, system: ScheduleSystem) -> bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we return a Result here, or at least have some docs? The meaning of the bool is unclear to me.

@alice-i-cecile alice-i-cecile added the M-Needs-Release-Note Work that should be called out in the blog due to impact label Oct 3, 2025
@dloukadakis dloukadakis added D-Straightforward Simple bug fixes and API improvements, docs, test and examples and removed M-Needs-Release-Note Work that should be called out in the blog due to impact labels Oct 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note.

Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes.

@alice-i-cecile
Copy link
Member

This should be added to the release note for the system removal PR :) Good API though!

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 3, 2025
@alice-i-cecile alice-i-cecile added this to the 0.18 milestone Oct 3, 2025
@dloukadakis dloukadakis added M-Needs-Release-Note Work that should be called out in the blog due to impact S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Oct 3, 2025
@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Dev-Tools Tools used to debug Bevy applications. S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed M-Needs-Release-Note Work that should be called out in the blog due to impact S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note.

Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes.

@alice-i-cecile alice-i-cecile added the M-Needs-Release-Note Work that should be called out in the blog due to impact label Oct 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note.

Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile left review comments

Assignees
No one assigned
Labels
A-Dev-Tools Tools used to debug Bevy applications. A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples M-Needs-Release-Note Work that should be called out in the blog due to impact S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged
Projects
None yet
Milestone
0.18
Development

Successfully merging this pull request may close these issues.
3 participants
@hymm @alice-i-cecile @dloukadakis