[SGP-24215] Pass a timeout argument to requests calls #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our Marketo API calls hang for 30+ minutes, blocking an entire Celery queue while they do so. By default, the
requestslibrary does not implement any timeout. You have to pass atimeoutargument torequestscalls (see docs). Unfortunately, the marketo library doesn't provide any method of passing arguments down to individualrequestscalls, so we need to implement that ourselves.Usage is as follows:
The
requests_timeoutparameter must be an integer. It will be passed to allrequests.<method>calls used in the library. Defaults toNone, i.e., no timeout.