Fix JS_HasException() when null is thrown
#313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chqrlie
approved these changes
May 31, 2024
Collaborator
chqrlie
left a comment
chqrlie
left a comment
There was a problem hiding this comment.
Using JS_UNINITIALIZED is a clever solution to allow for any valid value to be thrown.
Contributor
|
@chqrlie Shall this be merged? |
nickva
added a commit
to apache/couchdb
that referenced
this pull request
Jul 18, 2024
Update from latest master. Bring in these two fixes: * bellard/quickjs#302 * bellard/quickjs#313
nickva
added a commit
to apache/couchdb
that referenced
this pull request
Jul 18, 2024
Update from latest master. Bring in these two fixes: * bellard/quickjs#302 * bellard/quickjs#313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #312